[PATCH] D121510: [Support] Introduce the BLAKE3 hashing function implementation

[Nico Weber via Phabricator via llvm-commits]

thakis added inline comments.


================
Comment at: llvm/lib/Support/BLAKE3/CMakeLists.txt:47
+  ${LLVM_BLAKE3_FILES}
+  PARENT_SCOPE
+)
----------------
Out of interest, why is there a dedicated CMakeLists.txt file that does nothing but set a variable in the cmake file one level further up? It'd be more usual to either have this in the CMakeLists.txt file on further up, or make this declare an object library in this CMakeLists.txt file here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121510/new/

https://reviews.llvm.org/D121510