[PATCH] D122382: [SelectionDAG] Don't create illegally-typed nodes while constant folding

[Craig Topper via Phabricator via llvm-commits]

craig.topper added a comment.

Did this start failing because we no longer pre-check that all the build vector operands are constants like we did in llvm 13?



================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp:5614
+        // fail to constant fold we can't guarantee the (dead) nodes we're
+        // creating will be cleaned up before being visited for legalizatoin.
+        if (NewNodesMustHaveLegalTypes &&
----------------
legalizatoin -> legalization


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122382/new/

https://reviews.llvm.org/D122382