[PATCH] D122416: [llvm][NFC] Prefer using variadic isa<> over non-variadic isa<>s

Hirochika Matsumoto via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 24 11:02:22 PDT 2022


hkmatsumoto added inline comments.


================
Comment at: llvm/lib/Analysis/Lint.cpp:410
              &I);
-    Assert(!isa<Function>(UnderlyingObject) &&
-               !isa<BlockAddress>(UnderlyingObject),
+    Assert((!isa<Function, BlockAddress>(UnderlyingObject)),
            "Undefined behavior: Write to text section", &I);
----------------
See https://stackoverflow.com/questions/38030048/too-many-arguments-provided-to-function-like-macro-invocation for this new parenthesis.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122416/new/

https://reviews.llvm.org/D122416



More information about the llvm-commits mailing list