[PATCH] D122416: [llvm][NFC] Prefer using variadic isa<> over non-variadic isa<>s

Hirochika Matsumoto via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 24 10:20:11 PDT 2022


hkmatsumoto created this revision.
Herald added subscribers: ormris, dexonsmith, okura, kuter, rogfer01, hiraditya.
Herald added a project: All.
hkmatsumoto requested review of this revision.
Herald added a reviewer: jdoerfert.
Herald added a reviewer: sstefan1.
Herald added subscribers: llvm-commits, vkmr.
Herald added a reviewer: baziotis.
Herald added a project: LLVM.

Given that isa<Foo, Bar>(A) is equivalent to isa<Foo>(A) || isa<Bar>(A),
we can refactor the codebase as follows:

- Change isa<Foo>(A) || isa<Bar>(A) to isa<Foo, Bar>(A)
- Change !isa<Foo>(A) && !isa<Bar>(A) to !isa<Foo, Bar>(A)

Fixes https://github.com/llvm/llvm-project/issues/45828


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D122416

Files:
  llvm/lib/Analysis/Lint.cpp
  llvm/lib/CodeGen/TypePromotion.cpp
  llvm/lib/IR/AsmWriter.cpp
  llvm/lib/Transforms/IPO/Attributor.cpp
  llvm/lib/Transforms/IPO/HotColdSplitting.cpp
  llvm/lib/Transforms/Vectorize/VPlan.cpp
  llvm/lib/Transforms/Vectorize/VPlanTransforms.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D122416.417974.patch
Type: text/x-patch
Size: 4898 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220324/34a838e0/attachment.bin>


More information about the llvm-commits mailing list