[PATCH] D122044: [AMDGPU] New gfx940 mfma instructions

Thu Mar 24 10:15:17 PDT 2022

foad added inline comments.

================
Comment at: llvm/lib/Target/AMDGPU/VOP3PInstructions.td:745

+defm V_MFMA_I32_32X32X16I8       : VOP3P_Real_MFMA_gfx940 <0x56, "v_mfma_i32_32x32x16_i8">;
+defm V_MFMA_I32_16X16X32I8       : VOP3P_Real_MFMA_gfx940 <0x57, "v_mfma_i32_16x16x32_i8">;
----------------
rampitec wrote:
> rampitec wrote:
> > foad wrote:
> > > ... but here the same instruction name does have an underscore.
> > These are asm aliases. The same aliases with and w/o underscores supported by the SP3. In fact Justin and me decided we want these aliases to make it easier to adopt old kernels.
> Look at the ai-gfx940.s lines 282 and 286 which tests both names are accepted.
OK. No further comments from me :)

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122044/new/

https://reviews.llvm.org/D122044