[PATCH] D120905: [demangler] Add operator precedence

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 24 09:31:03 PDT 2022


dblaikie added a comment.

In D120905#3404948 <https://reviews.llvm.org/D120905#3404948>, @urnathan wrote:

> In D120905#3403253 <https://reviews.llvm.org/D120905#3403253>, @dblaikie wrote:
>
>> Looks like the buildbot failures include two timeouts, and a format check that's already failing, perhaps? If that's it, then seems OK to me.
>
> Yes, the format failure is because the entire test program is badly formatted, and mostly contained in one many-thousand-line array, which any new mangling test adds elements too.  And hence the formatter reformats the entire array.  (and reformatting the array is (a) unwanted and (b) blows up the diff limit of phabricator)

Yeah - if you like, it's probably fine to reformat that and commit it directly without review before or after this patch. But no big deal either way.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120905/new/

https://reviews.llvm.org/D120905



More information about the llvm-commits mailing list