[PATCH] D122226: [llvm-pdbutil] Move InputFile/FormatUtil/LinePrinter to the PDB library.

[Carlos Alberto Enciso via Phabricator via llvm-commits]

CarlosAlbertoEnciso updated this revision to Diff 417933.
CarlosAlbertoEnciso added a comment.

Add couple of // TODO comments for:

- Move `Filters` inside the `LinePrinter` class.
- Change callbacks used by the symbol group traversal to function-refs (de-templatify them).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122226/new/

https://reviews.llvm.org/D122226

Files:
  llvm/include/llvm/DebugInfo/PDB/Native/FormatUtil.h
  llvm/include/llvm/DebugInfo/PDB/Native/InputFile.h
  llvm/include/llvm/DebugInfo/PDB/Native/LinePrinter.h
  llvm/lib/DebugInfo/PDB/CMakeLists.txt
  llvm/lib/DebugInfo/PDB/Native/FormatUtil.cpp
  llvm/lib/DebugInfo/PDB/Native/InputFile.cpp
  llvm/lib/DebugInfo/PDB/Native/LinePrinter.cpp
  llvm/tools/llvm-pdbutil/BytesOutputStyle.cpp
  llvm/tools/llvm-pdbutil/BytesOutputStyle.h
  llvm/tools/llvm-pdbutil/CMakeLists.txt
  llvm/tools/llvm-pdbutil/DumpOutputStyle.cpp
  llvm/tools/llvm-pdbutil/DumpOutputStyle.h
  llvm/tools/llvm-pdbutil/ExplainOutputStyle.cpp
  llvm/tools/llvm-pdbutil/ExplainOutputStyle.h
  llvm/tools/llvm-pdbutil/FormatUtil.cpp
  llvm/tools/llvm-pdbutil/FormatUtil.h
  llvm/tools/llvm-pdbutil/InputFile.cpp
  llvm/tools/llvm-pdbutil/InputFile.h
  llvm/tools/llvm-pdbutil/LinePrinter.cpp
  llvm/tools/llvm-pdbutil/LinePrinter.h
  llvm/tools/llvm-pdbutil/MinimalSymbolDumper.cpp
  llvm/tools/llvm-pdbutil/MinimalTypeDumper.cpp
  llvm/tools/llvm-pdbutil/PrettyBuiltinDumper.cpp
  llvm/tools/llvm-pdbutil/PrettyClassDefinitionDumper.cpp
  llvm/tools/llvm-pdbutil/PrettyClassLayoutGraphicalDumper.cpp
  llvm/tools/llvm-pdbutil/PrettyCompilandDumper.cpp
  llvm/tools/llvm-pdbutil/PrettyEnumDumper.cpp
  llvm/tools/llvm-pdbutil/PrettyExternalSymbolDumper.cpp
  llvm/tools/llvm-pdbutil/PrettyFunctionDumper.cpp
  llvm/tools/llvm-pdbutil/PrettyTypeDumper.cpp
  llvm/tools/llvm-pdbutil/PrettyTypedefDumper.cpp
  llvm/tools/llvm-pdbutil/PrettyVariableDumper.cpp
  llvm/tools/llvm-pdbutil/StreamUtil.cpp
  llvm/tools/llvm-pdbutil/TypeReferenceTracker.cpp
  llvm/tools/llvm-pdbutil/TypeReferenceTracker.h
  llvm/tools/llvm-pdbutil/llvm-pdbutil.cpp
  llvm/tools/llvm-pdbutil/llvm-pdbutil.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D122226.417933.patch
Type: text/x-patch
Size: 41192 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220324/330a1039/attachment.bin>