[PATCH] D122372: [lld][COFF] Fix TypeServerSource lookup on GUID collisions

Tobias Hieta via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 24 06:28:29 PDT 2022


thieta added a comment.

In D122372#3405209 <https://reviews.llvm.org/D122372#3405209>, @aganea wrote:

> Can you please craft a small test that would showcase the problem? The test shall fail before your change, and should succeed after.

Yeah absolutely - the discussion got a little split between here and Github I think - but I said that I will add a test if we can agree on the approach for how to handle the root cause. The test is kind of hard to get right as well - since it requires we load two PDB files with the same GUID and then we need to make sure they end up loaded in a order that messes with the functiontype table - so I am not sure exactly how that is going to work.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122372/new/

https://reviews.llvm.org/D122372



More information about the llvm-commits mailing list