[PATCH] D121641: MemoryBuiltins: also check function definition for allocalign

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 24 06:23:05 PDT 2022


nikic added a comment.

In D121641#3380900 <https://reviews.llvm.org/D121641#3380900>, @durin42 wrote:

> In D121641#3380875 <https://reviews.llvm.org/D121641#3380875>, @nikic wrote:
>
>> This should have a test, e.g. in InstCombine.
>
> That happens as part of D121642 <https://reviews.llvm.org/D121642> - is that okay?

I'd suggest pre-committing the tests, so that the test diff then shows up in the individual patches.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121641/new/

https://reviews.llvm.org/D121641



More information about the llvm-commits mailing list