[PATCH] D114342: ConvertUTF, new wrapper API

Aaron Ballman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 24 04:50:48 PDT 2022


aaron.ballman added a comment.

In D114342#3404393 <https://reviews.llvm.org/D114342#3404393>, @MarcusJohnson91 wrote:

> In D114342#3402219 <https://reviews.llvm.org/D114342#3402219>, @aaron.ballman wrote:
>
>> In D114342#3401916 <https://reviews.llvm.org/D114342#3401916>, @cor3ntin wrote:
>>
>>> @MarcusJohnson91 The failure looks unrelated. The test looks good, I think we can try again. I'd rather wait for @aaron.ballman in case you need to revert again though!
>>
>> Agreed that the precommit CI failure looks unrelated and that the test seems reasonable. I've landed again in d14ccbc2e88d2cebd27cdd829879ded10ba0c9ea <https://reviews.llvm.org/rGd14ccbc2e88d2cebd27cdd829879ded10ba0c9ea> and we'll see how happy the build bots are.
>
> Seems like they were happy after all? 🤞

I believe so -- I've not seen any related failures come across my inbox, at least.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114342/new/

https://reviews.llvm.org/D114342



More information about the llvm-commits mailing list