[PATCH] D121655: [llvm-profgen] Read sample profiles for post-processing.

[Hongtao Yu via Phabricator via llvm-commits]

hoy added inline comments.


================
Comment at: llvm/test/tools/llvm-profgen/cold-profile-trimming-symbolized.test:2
+; RUN: llvm-profgen --format=text --unsymbolized-profile=%S/Inputs/cold-profile-trimming.raw.prof --binary=%S/Inputs/inline-noprobe2.perfbin --output=%t1 --use-offset=0
+; RUN: llvm-profgen --format=text --symbolized-profile=%t1 --binary=%S/Inputs/inline-noprobe2.perfbin --output=%t2 --trim-cold-profile=1 --profile-summary-cold-count=1000
+; RUN: FileCheck %s --input-file %t2 --check-prefix=CHECK-TRIM
----------------
wenlei wrote:
> Maybe we should probably support no-diff llvm profile to llvm profile conversion? You mentioned the call site samples as a difference and I'm wondering whether this is an easy to fix difference. 
The check here is to make sure the profile post-processing is effective. There's no cross-type profile conversion here. The non-diff profile conversion I mentioned was about converting CS flat profile to CS nest which should be independent of this diff. I can make a separate fix for that though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121655/new/

https://reviews.llvm.org/D121655