[PATCH] D121296: [GlobalIsel][X86] Legalization of G_IS_FPCLASS

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added a comment.

Could also use FewerElementsVector handling



================
Comment at: llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp:7901
+  Function &F = MI.getParent()->getParent()->getFunction();
+  if (!F.getAttributes().hasFnAttr(llvm::Attribute::StrictFP)) {
+    if (Test == fcZero) {
----------------
Isn't this implied by this not being a strict opcode?


================
Comment at: llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp:7940
+
+  Optional<MachineInstrBuilder> Res;
+  const auto appendResult = [&](MachineInstrBuilder PartialRes) {
----------------
This will function the same without Optional


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121296/new/

https://reviews.llvm.org/D121296