[PATCH] D122191: [AMDGPU] Support gfx940 smfmac instructions

Konstantin Zhuravlyov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 23 12:43:54 PDT 2022


kzhuravl accepted this revision.
kzhuravl added a comment.
This revision is now accepted and ready to land.

LGTM with a minor nit



================
Comment at: llvm/lib/Target/AMDGPU/VOPInstructions.td:395
+  let Inst{22-16} = op;
+  let Inst{31-23} = 0x1a7; //encoding
+  let Inst{40-32} = src0{8-0};
----------------
space between // and encoding?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122191/new/

https://reviews.llvm.org/D122191



More information about the llvm-commits mailing list