[PATCH] D122245: [Disassember][NFCI] Use strong type for instruction decoder

Maksim Panchenko via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 23 10:56:16 PDT 2022


maksfb added a comment.

In D122245#3401920 <https://reviews.llvm.org/D122245#3401920>, @foad wrote:

> Can you explain which ones are removed? In the AMDGPU backend it looks like they are all still required, to cast from `MCDisassembler *` to `AMDGPUDisassembler *`.

Right, I removed casts where no further code changes were required. E.g., if the pointer was used to call an `AMDGPUDisassembler`-specific function, we still need to cast. It's possible I've missed some cases. Please let me know.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122245/new/

https://reviews.llvm.org/D122245



More information about the llvm-commits mailing list