[PATCH] D121862: [ProfSampleLoader] When disable-sample-loader-inlining is true, merge profiles of inlined instances to outlining versions.

[Mingming Liu via Phabricator via llvm-commits]

luna added a comment.

thanks for the reviews!



================
Comment at: llvm/lib/Transforms/IPO/SampleProfile.cpp:1509
                      Candidate.CallsiteDistribution};
+
         if (tryPromoteAndInlineCandidate(F, Candidate, SumOrigin, Sum,
----------------
wenlei wrote:
> I'd avoid random white space changes in general, unless you're intentionally fixing some format issues.
Remove the added black lines here, and three other places.

> unless you're intentionally fixing some format issues.

(This is opinion-based, so just to explain why I add so many blank lines)

Blank lines were added when I didn't see a curly brace around one-line if-else,  even if it's the code style ( https://llvm.org/docs/CodingStandards.html#don-t-use-braces-on-simple-single-statement-bodies-of-if-else-loop-statements)

I'll keep avoid adding blank lines around untouched lines.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121862/new/

https://reviews.llvm.org/D121862