[PATCH] D122286: [AMDGPU] Add missing testcase for SGPR to AGPR copy
Stanislav Mekhanoshin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Mar 23 08:46:38 PDT 2022
rampitec added inline comments.
================
Comment at: llvm/lib/Target/AMDGPU/SIInstrInfo.cpp:628
+ break;
+ Tmp = Tmp2;
RS.setRegUsed(Tmp);
----------------
cdevadas wrote:
> Shouldn't this be Tmp = MIN (Tmp, Tmp2) if Tmp2 is a valid RegNo?
> RS might return a higher number than the reserved.
> (Unrelated to this patch)
No. It should rotate 3 different VGPRs with each call.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D122286/new/
https://reviews.llvm.org/D122286
More information about the llvm-commits
mailing list