[PATCH] D122319: NFC: [LICM] Update some stale comments

[Djordje Todorovic via Phabricator via llvm-commits]

djtodoro created this revision.
djtodoro added a reviewer: nikic.
Herald added subscribers: asbirlea, hiraditya.
Herald added a project: All.
djtodoro requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

After removing the `MaybePromotable`, some comments became stale. This improves them.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D122319

Files:
  llvm/lib/Transforms/Scalar/LICM.cpp


Index: llvm/lib/Transforms/Scalar/LICM.cpp
===================================================================
--- llvm/lib/Transforms/Scalar/LICM.cpp
+++ llvm/lib/Transforms/Scalar/LICM.cpp
@@ -482,8 +482,7 @@
       PredIteratorCache PIC;
 
       // Promoting one set of accesses may make the pointers for another set
-      // loop invariant, so run this in a loop (with the MaybePromotable set
-      // decreasing in size over time).
+      // loop invariant, so run this in a loop.
       bool Promoted = false;
       bool LocalPromoted;
       do {
@@ -2276,8 +2275,7 @@
     return false;
   };
 
-  // Populate AST with potentially promotable accesses and remove them from
-  // MaybePromotable, so they will not be checked again on the next iteration.
+  // Populate AST with potentially promotable accesses.
   SmallPtrSet<Value *, 16> AttemptingPromotion;
   foreachMemoryAccess(MSSA, L, [&](Instruction *I) {
     if (IsPotentiallyPromotable(I)) {


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D122319.417621.patch
Type: text/x-patch
Size: 963 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220323/a289a57f/attachment.bin>