[PATCH] D122181: Cleanup includes: Transforms/Instrumentation & Transforms/Vectorize

serge via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 23 02:29:21 PDT 2022


serge-sans-paille added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:74
 #include "llvm/IR/ValueHandle.h"
+#ifdef EXPENSIVE_CHECKS
 #include "llvm/IR/Verifier.h"
----------------
MaskRay wrote:
> Consider including it unconditionally. The header is small
Unfortunately, this doesn't help with IWYU reports (it leads to a false unused incldue when running the checker under `-UEXPENSIVE_CHECK`), that's why I'm guarding them.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122181/new/

https://reviews.llvm.org/D122181



More information about the llvm-commits mailing list