[PATCH] D109577: [LNT] Fixed incorrect orders behavior in case of miss formatted llvm_project_revision

Pavel Kosov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 23 00:31:17 PDT 2022


kpdev42 added a comment.

In D109577#3355478 <https://reviews.llvm.org/D109577#3355478>, @cmatthews wrote:

> Actually, I just realized this has a serious bug. The hash function in python is salted, so results are different between process restarts.
>
> https://docs.python.org/3/reference/datamodel.html#object.__hash__
>
> Can you use a different hash function?

Could you please advice a preferable hash function implementation?

Note: I just want to clarify, that this solution (hash(str)) is a workaround to fix a problem in case when llvm_project_revision does not contain any digit. It did not intend to fix the sorting.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109577/new/

https://reviews.llvm.org/D109577



More information about the llvm-commits mailing list