[PATCH] D121785: The [3/3] Fix mangle problem when variable used in inline asm (Support ARR[BaseReg+IndexReg+..] in PIC model)

Kan Shengchen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 22 23:44:43 PDT 2022


skan accepted this revision.
skan added a comment.
This revision is now accepted and ready to land.

LGTM except the doc part.



================
Comment at: llvm/docs/LangRef.rst:5058
+- ``P``: Print a memory reference used as the argument of a call instruction or
+  used with explicit base reg and index reg as its offset. So it can not use
+  additional regs to present the memory reference. (E.g. omit ``(rip)``, even
----------------
I suggest the following doc:

Print a memory reference or operand for use as the argument of a call instruction (e.g. omit `(rip)`, even though it's PC-relative) or a memory reference with explict base reg and index reg.



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121785/new/

https://reviews.llvm.org/D121785



More information about the llvm-commits mailing list