[PATCH] D121183: [RISCV] Generate correct ELF EFlags when .ll file has target-abi attribute

Tue Mar 22 23:18:16 PDT 2022

StephenFan added inline comments.

================
Comment at: llvm/lib/Target/RISCV/MCTargetDesc/RISCVMCTargetDesc.cpp:89
+
+  // Check if Feature string is valid
+  auto ISAInfo =
----------------
khchen wrote:
> StephenFan wrote:
> > khchen wrote:
> > > Why do we need to have additional check here?
> > > Could we have a test to show this check could catch an error?
> > The reason is the same as what I said above.
> I think we could remove this checking and update expected ERROR message in `mattr-invalid-combination.ll` and `mattr-invalid-combination.s` from `standard user-level extension 'e' requires 'rv32'` to `RV32E can't be enabled for an RV64 target` in another NFC patch.
Hi @khchen, D122290 addresses your suggestion about this.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121183/new/

https://reviews.llvm.org/D121183