[PATCH] D122148: [SLP] Peak into loads when hitting the RecursionMaxDepth

[Vasileios Porpodas via Phabricator via llvm-commits]

vporpo added a comment.

Thank you for taking the time to measure the compilation time with an increased max-depth limit.

I am not sure what the max-depth limit was designed to be used for, probably for testing gathers in lit test? But I don't think that it is a very good way of limiting compilation time. A better option would be to limit the total number of nodes in the graph, by simply counting the entries in `buildTree_rec()`. So I would assume that increasing the max-depth limit should be relatively safe. If we run into compile-time issues, we can introduce the `buildTree_rec()` entry counter. @ABataev @RKSimon any thoughts on this?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122148/new/

https://reviews.llvm.org/D122148