[PATCH] D122274: [AArch64] Fix AArch64TargetParser.def to match AArch64.td.

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 22 17:06:07 PDT 2022


efriedma created this revision.
efriedma added reviewers: t.p.northover, dmgreen, stuij, bsmith, mubashar_, CarolineConcatto, ab, MarkMurrayARM, wxz2020, pbarrio, joelkevinjones, joel_k_jones.
Herald added a subscriber: kristof.beyls.
Herald added a project: All.
efriedma requested review of this revision.
Herald added a project: LLVM.

Currently, we have two different lists of features each CPU supports... and those lists aren't consistent. This patch assumes AArch64.td is right, and tries to fix AArch64TargetParser to match.

That said... I really have no idea which feature list is actually right. I don't have these CPUs, and I can't find documentation.  So I'd appreciate input on whether my "corrections" are actually correct.

Probably we should try to unify the two lists at some point, but synchronizing them seems like a prerequisite to that anyway.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D122274

Files:
  llvm/include/llvm/Support/AArch64TargetParser.def
  llvm/unittests/Support/TargetParserTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D122274.417442.patch
Type: text/x-patch
Size: 15517 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220323/096becce/attachment.bin>


More information about the llvm-commits mailing list