[PATCH] D122251: [lit] Use sharding for GoogleTest format

Tue Mar 22 16:37:57 PDT 2022

ychen added a comment.

Do we support using upstream googletest instead of the in-tree copy for the unit test?

================
Comment at: llvm/utils/lit/lit/TestingConfig.py:31
                      'VCToolsinstallDir', 'VSINSTALLDIR', 'WindowsSdkDir',
-                     'WindowsSDKLibVersion', 'SOURCE_DATE_EPOCH']
+                     'WindowsSDKLibVersion', 'SOURCE_DATE_EPOCH','GTEST_FILTER']

----------------
This is the replacement for `--filter` and `--filter-not` for unit tests. Since GTEST_FILTER takes a different format of regex than `--filter`/`--filter-not` , passing `--filter` and `--filter-not` arguments for unit tests to `GTEST_FILTER` could be confusing to the lit user. IMHO, it would be more clear to just use `GTEST_FILTER`. The drawback is sacrificing a bit of consistency. Please let me know if you think otherwise.

About `--xfail` /`--xfail-not`, tests for D106022 did not cover unit tests, I could add more tests and the handling for sharding in a follow-up patch considering this patch is already big.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122251/new/

https://reviews.llvm.org/D122251