[PATCH] D116787: [llvm-readobj][MachO] Add option to sort the symbol table before dumping (MachO only, for now).

Vy Nguyen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 22 16:00:18 PDT 2022


oontvoo added a comment.

@jhenderson sorry this has taken awhile - was busy with other stuff - I've doubled checked the crash I was talking about - turned out it was because of getSymbolName() (completely unrelated)  So yeah, you're right - storing the SymbolRef is safe. Reworked the patch per your suggestion (with some modification).
PTAL. thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116787/new/

https://reviews.llvm.org/D116787



More information about the llvm-commits mailing list