[PATCH] D122156: [lld][Macho][NFC] Encapsulate priorities map in a priority class
Jez Ng via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Mar 22 13:41:30 PDT 2022
int3 added inline comments.
================
Comment at: lld/MachO/SectionPriorities.cpp:252
-static Optional<size_t> getSymbolPriority(const Defined *sym) {
+Optional<size_t> macho::PriorityBuilder::getSymbolPriority(const Defined *sym) {
if (sym->isAbsolute())
----------------
oh yeah -- unlike global functions, class method definitions don't actually need the `macho::` prefix (I believe because clang first performs name lookup on PriorityBuilder, so it knows in which namespace this code belongs to)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D122156/new/
https://reviews.llvm.org/D122156
More information about the llvm-commits
mailing list