[PATCH] D114342: ConvertUTF, new wrapper API

Tue Mar 22 12:56:08 PDT 2022

MarcusJohnson91 added a comment.

In D114342#3400272 <https://reviews.llvm.org/D114342#3400272>, @aaron.ballman wrote:

> In D114342#3400174 <https://reviews.llvm.org/D114342#3400174>, @MarcusJohnson91 wrote:
>
>> In D114342#3400086 <https://reviews.llvm.org/D114342#3400086>, @aaron.ballman wrote:
>>
>>> In D114342#3399850 <https://reviews.llvm.org/D114342#3399850>, @MarcusJohnson91 wrote:
>>>
>>>> In D114342#3399200 <https://reviews.llvm.org/D114342#3399200>, @aaron.ballman wrote:
>>>>
>>>>> LGTM, @MarcusJohnson91, do you need someone to land this on your behalf? If so, what name and email address would you like used for patch attribution?
>>>>
>>>> Hey Aaron, yes, let's go with my real name, Marcus Johnson and MarcusLJohnson1991 at gmail
>>>>
>>>> thanks :)
>>>
>>> Thanks for the patch! I've landed on your behalf in c3460689288abc98c91d8d6bffa74be9eb16c74d <https://reviews.llvm.org/rGc3460689288abc98c91d8d6bffa74be9eb16c74d>. (I can't close the review because @Bigcheese still has marked as requesting changes.)
>>
>> Thanks so much, I'll try to close it :)
>
> Unfortunately, I had to revert in a6beb18b845ca8548319d08df9eea46c87e1e533 <https://reviews.llvm.org/rGa6beb18b845ca8548319d08df9eea46c87e1e533> because the commit broke at least one of the build bots: https://lab.llvm.org/buildbot#builders/100/builds/13947. Can you investigate?

Awww

I'll check into it.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114342/new/

https://reviews.llvm.org/D114342