[PATCH] D122217: [X86] Remove TB_NO_REVERSE for 2 memory folding entries

[Craig Topper via Phabricator via llvm-commits]

craig.topper added a comment.

I would argue that the MMX_MOVD64from64rr entry should fold to MMX_MOVQ64mr since it is one by shorter to encode. And that wouldn't be reversible since MMX_MOVD64from64rr is 64-bit mode instruction and MMX_MOVQ64mr isn't.

For the other one I'm not sure what scenario it would make sense to unfold it. It would introduce an intermediate GPR register that didn't otherwise exist. But since store unfolding is never used, I guess It doesn't really matter.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122217/new/

https://reviews.llvm.org/D122217