[llvm] ef9cf86 - [WebAssembly][NFC] Delete type checking logic for removed ref.null instruction

Alex Bradbury via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 22 09:24:21 PDT 2022


Author: Alex Bradbury
Date: 2022-03-22T16:24:05Z
New Revision: ef9cf86eb0ded6f5460f5870bcb90530a7411a60

URL: https://github.com/llvm/llvm-project/commit/ef9cf86eb0ded6f5460f5870bcb90530a7411a60
DIFF: https://github.com/llvm/llvm-project/commit/ef9cf86eb0ded6f5460f5870bcb90530a7411a60.diff

LOG: [WebAssembly][NFC] Delete type checking logic for removed ref.null instruction

D114979 changed the textual formal of ref.null - dropping ref.null in
favour of ref.null_extern and ref.null_func. Therefore, the type checker
no longer needs logic to handle "ref.null".

Differential Revision: https://reviews.llvm.org/D122123

Added: 
    

Modified: 
    llvm/lib/Target/WebAssembly/AsmParser/WebAssemblyAsmTypeCheck.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Target/WebAssembly/AsmParser/WebAssemblyAsmTypeCheck.cpp b/llvm/lib/Target/WebAssembly/AsmParser/WebAssemblyAsmTypeCheck.cpp
index d9f96d9a64190..fedc61100fc3b 100644
--- a/llvm/lib/Target/WebAssembly/AsmParser/WebAssemblyAsmTypeCheck.cpp
+++ b/llvm/lib/Target/WebAssembly/AsmParser/WebAssemblyAsmTypeCheck.cpp
@@ -303,9 +303,6 @@ bool WebAssemblyAsmTypeCheck::typeCheck(SMLoc ErrorLoc, const MCInst &Inst) {
     // catch instruction pushes values whose types are specified in the tag's
     // "params" part
     Stack.insert(Stack.end(), Sig->Params.begin(), Sig->Params.end());
-  } else if (Name == "ref.null") {
-    auto VT = static_cast<wasm::ValType>(Inst.getOperand(0).getImm());
-    Stack.push_back(VT);
   } else if (Name == "unreachable") {
     Unreachable = true;
   } else {


        


More information about the llvm-commits mailing list