[PATCH] D122156: [lld][Macho][NFC] Encapsulate priorities map in a priority class
Roger Kim via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Mar 22 09:02:51 PDT 2022
Roger marked an inline comment as done.
Roger added inline comments.
================
Comment at: lld/MachO/SectionPriorities.cpp:37
+PriorityBuilder macho::priorityBuilder;
+
----------------
thevinster wrote:
> nit: Since we are already namespacing macho, can we drop the `macho::` everywhere in this file?
the code does not compile without `macho::`. I'm not sure exactly why but it appears to be necessary.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D122156/new/
https://reviews.llvm.org/D122156
More information about the llvm-commits
mailing list