[PATCH] D122020: [WebAssembly] Add tests for the Asm type checker

[Alex Bradbury via Phabricator via llvm-commits]

asb added inline comments.


================
Comment at: llvm/test/MC/WebAssembly/type-checker-return.s:3
+
+; XFAIL: *
+
----------------
sbc100 wrote:
> asb wrote:
> > sbc100 wrote:
> > > asb wrote:
> > > > sbc100 wrote:
> > > > > What is this line?   (is semi-colon a comment marker in .s files?)
> > > > It is, but you're right it's confusing to have alongside `#` comments. The XFAIL is picked up by lit and indicates the test is expected to fail (in this case, the RUN line will return a non-zero value).
> > > Oh, I normally use the `# RUN: not ...` for that.
> > That's a good way of checking for a non-zero exit value (as is done in type-checker-errors.s), but XFAIL has the advantage of marking a test as something that _should_ work, and having it show up in the test stats as such.
> > 
> > Happy to drop this file and just try to land type-checker-errors.s if that's preferred?
> Great!  That makes sense now. Thanks for clarifying.
Thanks for the quick review, I really appreciate it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122020/new/

https://reviews.llvm.org/D122020