[PATCH] D122152: [InstCombine] Fold two select patterns into and-or

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 22 08:03:45 PDT 2022


RKSimon added a comment.

In D122152#3396833 <https://reviews.llvm.org/D122152#3396833>, @bcl5980 wrote:

> In D122152#3396735 <https://reviews.llvm.org/D122152#3396735>, @RKSimon wrote:
>
>> I'm almost afraid to ask - but should we consider supporting this with freeze?
>
> Which way is better do you think?

I'm of the opinion we should start using freeze more in general codegen - using isGuaranteedNotToBePoison is very limiting to how often the combine will ever get used.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122152/new/

https://reviews.llvm.org/D122152



More information about the llvm-commits mailing list