[PATCH] D122205: [LoopIdiom] Merge TBAA of adjacent stores when creating memset

Tue Mar 22 06:52:40 PDT 2022

jeroen.dobbelaere added a comment.

In D122205#3399442 <https://reviews.llvm.org/D122205#3399442>, @steplong wrote:

> In D122205#3399389 <https://reviews.llvm.org/D122205#3399389>, @jeroen.dobbelaere wrote:
>
>> Unfortunately, the context of this patch is not available :(
>
> Whoops, should have explained the context. We were seeing GVN remove a load that had a TBAA that matched the 2nd store because GVN determined that it didn't match the TBAA on the memset that was created. The memset had the TBAA of the first store.

That is also handy to have as extra information, and should be added to the description.

But I was aiming for the the context of the full file instead of just the changes:

  `git diff HEAD~1 -U999999 > mypatch.patch` 

(see  https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface)

Thanks,

Jeroen

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122205/new/

https://reviews.llvm.org/D122205