[PATCH] D116462: [SPIRV 3/6] Add MC layer, object file support and InstPrinter

Tue Mar 22 05:09:30 PDT 2022

iliya-diyachkov added a comment.

In D116462#3376700 <https://reviews.llvm.org/D116462#3376700>, @MaskRay wrote:

> If you use a recent Clang to build llvm-project, there are several warnings:
>
>   llvm/lib/Bitcode/Writer/BitcodeWriter.cpp:4859:11: warning: enumeration value 'SPIRV' not handled in switch [-Wswitch]
>   llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:2106:11: warning: enumeration value 'SPIRV' not handled in switch [-Wswitch]
>   llvm/lib/Target/ARM/AsmParser/ARMAsmParser.cpp:6368:11: warning: enumeration value 'IsSPIRV' not handled in switch [-Wswitch]
>   
>   # I did not check whether this was due to a previous patch
>   llvm/lib/Target/SPIRV/MCTargetDesc/SPIRVBaseInfo.cpp:532:3: warning: default label in switch which covers all enumeration values [-Wcovered-switch-default]
>
> Does SPIRV need TargetLoweringObjectFileSPIRV? When GOFF was added in D106380 <https://reviews.llvm.org/D106380>, there was a test in test/CodeGen/SystemZ
>
> This patch introduces a good chunk of MC stuff but there seems no accompanying test.

@MaskRay as I understand the issues have been solved (see my previous replies and the updated patch). If yes, please approve this patch.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116462/new/

https://reviews.llvm.org/D116462