[PATCH] D121600: [Codegen][tablgen][NFC] Allow meta instruction to be target dependent
Bjorn Pettersson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Mar 22 04:14:25 PDT 2022
bjope added inline comments.
Herald added a subscriber: StephenFan.
================
Comment at: llvm/include/llvm/CodeGen/MachineInstr.h:817
+ /// executable instructions.
+ bool isMetaInstruction(QueryType Type = AnyInBundle) const {
+ return hasProperty(MCID::Meta, Type);
----------------
@skan (and reviewerts): Did you consider what the default QueryType should be here?
Downstream we've been using IgnoreBundle for isMetaInstruction (similarly as for isPseudo above). And now a number of debug info related test cases started to fail.
Before your patch isMetaInstruction() returned false when being queried on a BUNDLE instruction. So I think it would be more safe to use IgnoreBundle unless you want to change that behavior. And I don't think usage of isMetaInstruction in for example llvm::calculateDbgEntityHistory is supposed to skip a bundle just because one of multiple instructions in a BUNDLE is a meta instruction.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121600/new/
https://reviews.llvm.org/D121600
More information about the llvm-commits
mailing list