[PATCH] D122003: Add support for more archs in `Triple::getArchTypeForLLVMName`

Antonio Frighetto via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 22 04:13:47 PDT 2022


antoniofrighetto added a comment.

I have updated the patch by removing the case for `x86_64`. Although it looks like that's a known problem in LLVM (converting the arch-name to `Triple::x86_64` and then back to string does not return the original name), this may warrant a separate fix; so that, should something break up, we may easily revert it, and not blame this change.

@probinson, considering that `getArchTypeForLLVMName` does not seem to be tested anywhere, and proposing a new one for this small change may not be worth it, could it make sense not to a provide a test at this time?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122003/new/

https://reviews.llvm.org/D122003



More information about the llvm-commits mailing list