[PATCH] D120169: [Debuginfo][LSR} Add support for salvaging variadic dbg.value intrinsics [2/2]

[Djordje Todorovic via Phabricator via llvm-commits]

djtodoro added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/LoopStrengthReduce.cpp:6209
+static void updateDVIWithLocation(DbgValueInst &DVI, Value *V,
+                                    SmallVectorImpl<uint64_t> &Ops) {
+  DVI.setRawLocation(ValueAsMetadata::get(V));
----------------
clang-format please


================
Comment at: llvm/lib/Transforms/Scalar/LoopStrengthReduce.cpp:6250
+  if (NumPreLSRElements == 0 && SalvageExpression->getNumElements() != 0) {
+    uint64_t StackTerminator[1] = {dwarf::DW_OP_stack_value};
+    SalvageExpression = DIExpression::append(SalvageExpression, StackTerminator);
----------------
no need for the variable here, it can be inlined into the call-site


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120169/new/

https://reviews.llvm.org/D120169