[PATCH] D122130: Verify parameter alignment attribute

[LuoYuanke via Phabricator via llvm-commits]

LuoYuanke updated this revision to Diff 417190.
LuoYuanke added a comment.

Address Phoebe's comments.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122130/new/

https://reviews.llvm.org/D122130

Files:
  llvm/lib/IR/Verifier.cpp
  llvm/test/Verifier/param-attr-align.ll


Index: llvm/test/Verifier/param-attr-align.ll
===================================================================
--- /dev/null
+++ llvm/test/Verifier/param-attr-align.ll
@@ -0,0 +1,11 @@
+; RUN: not llvm-as < %s 2>&1 | FileCheck %s
+
+; CHECK: Attribute 'align' exceed the max size 2^14
+define dso_local void @foo(i8* %p) {
+entry:
+  %p1 = bitcast i8* %p to <8 x float>*
+  call void @bar(<8 x float>* noundef byval(<8 x float>) align 32768 %p1)
+  ret void
+}
+
+declare dso_local void @bar(<8 x float>* %p)
Index: llvm/lib/IR/Verifier.cpp
===================================================================
--- llvm/lib/IR/Verifier.cpp
+++ llvm/lib/IR/Verifier.cpp
@@ -1813,6 +1813,16 @@
 
   if (PointerType *PTy = dyn_cast<PointerType>(Ty)) {
     if (Attrs.hasAttribute(Attribute::ByVal)) {
+      if (Attrs.hasAttribute(Attribute::Alignment)) {
+        Align AttrAlign = Attrs.getAlignment().valueOrOne();
+        // ISD::ArgFlagsTy::MemAlign only have 4 bits for alignment, so
+        // the alignment size should not exceed 2^15. Since encode(Align)
+        // would plus the shift value by 1, the alignment size should
+        // not exceed 2^14, otherwise it can NOT be properly lowered.
+        Align MaxAlign(1 << 15);
+        Assert(AttrAlign < MaxAlign,
+               "Attribute 'align' exceed the max size 2^14", V);
+      }
       SmallPtrSet<Type *, 4> Visited;
       Assert(Attrs.getByValType()->isSized(&Visited),
              "Attribute 'byval' does not support unsized types!", V);


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D122130.417190.patch
Type: text/x-patch
Size: 1518 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220322/698e422c/attachment.bin>