[PATCH] D121862: [ProfSampleLoader] When disable-sample-loader-inlining is true, merge profiles of inlined instances to outlining versions.

[Mingming Liu via Phabricator via llvm-commits]

luna added a comment.

In D121862#3398171 <https://reviews.llvm.org/D121862#3398171>, @davidxl wrote:

> When the option was introduced in https://reviews.llvm.org/D120344, I think the intention is to use it to disable both sampleloader inlining (pre/postlink), so perhaps we can just tighten the comment for the option and document that the profiles are merged back.
>
> If there is a need for prelink disabling in the future, we can introduce a new option for it (which does not merge profile back).

Done.

I modified the option description. The description become (unavoidably) verbose now. But since option description is a centralized place to convey the caveats. decided to make it the current way, so it's not easily missed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121862/new/

https://reviews.llvm.org/D121862