[PATCH] D122157: [lld][MachO][NFC] Nest the CallGraphSort inside the PriorityBuilder class

Jez Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 21 11:34:13 PDT 2022


int3 added a comment.

+1, I'm not convinced this makes the code clearer. I would prefer not to couple the declarations of CallGraphSort and PriorityBuilder. I don't think visibility of members is a big concern given that CallGraphSort is already declared in an anon namespace.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122157/new/

https://reviews.llvm.org/D122157



More information about the llvm-commits mailing list