[llvm] 826bdf5 - [lldb] Fix llvm::Optional summary provider

Dave Lee via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 21 10:03:24 PDT 2022


Author: Dave Lee
Date: 2022-03-21T10:03:16-07:00
New Revision: 826bdf51ff3185cac0d7f314c3422efe548dcdc4

URL: https://github.com/llvm/llvm-project/commit/826bdf51ff3185cac0d7f314c3422efe548dcdc4
DIFF: https://github.com/llvm/llvm-project/commit/826bdf51ff3185cac0d7f314c3422efe548dcdc4.diff

LOG: [lldb] Fix llvm::Optional summary provider

Differential Revision: https://reviews.llvm.org/D122041

Added: 
    

Modified: 
    llvm/utils/lldbDataFormatters.py

Removed: 
    


################################################################################
diff  --git a/llvm/utils/lldbDataFormatters.py b/llvm/utils/lldbDataFormatters.py
index 6326c4f65ec75..976aa71bfb45a 100644
--- a/llvm/utils/lldbDataFormatters.py
+++ b/llvm/utils/lldbDataFormatters.py
@@ -138,7 +138,11 @@ def GetOptionalValue(valobj):
 
 def OptionalSummaryProvider(valobj, internal_dict):
     val = GetOptionalValue(valobj)
-    return val.summary if val else 'None'
+    if val is None:
+        return 'None'
+    if val.summary:
+        return val.summary
+    return ''
 
 class OptionalSynthProvider:
     """Provides deref support to llvm::Optional<T>"""


        


More information about the llvm-commits mailing list