[PATCH] D122145: [SLP] Cluster ordering for loads

[Dave Green via Phabricator via llvm-commits]

dmgreen added a comment.

In D122145#3396562 <https://reviews.llvm.org/D122145#3396562>, @ABataev wrote:

> Just FYI D105986 <https://reviews.llvm.org/D105986>

Oh yeah, that's interesting. I had tried a few of your other patches, but not seen that one. It goes back before I was looking. It seems to change a lot more - is this one of the things it does? It's hard to tell with so many changes :)

One thing I was thinking of doing here was a kind of ordering-priority, and only cluster the loads if there wasn't anything else that looked like a better order. It seemed that a lot of the tests I tried did just fine with the clustered loads order though compared to any other, so I wasn't sure if it was wroth adding something like that. When I tried it, it was getting tripped up in the TopToBottom ordering, not being able to detect what counted as a better order.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122145/new/

https://reviews.llvm.org/D122145