[PATCH] D122091: [amdgpu] Elide module lds allocation in kernels with no callees

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added a comment.

In D122091#3396134 <https://reviews.llvm.org/D122091#3396134>, @JonChesterfield wrote:

> The other passes do know how much is allocated. I don't want to go digging around the IR looking for the llvm.donothing call, which iirc is removed before instruction selection

I don't understand this patch at all then.

> I can invert the sense of the attribute if you deem that important. Call it amdgpu-no-module-lds-needed or similar, with the same allocate when missing attribute behaviour.

It should be inverted (and doesn't need to have a string value), although it still feels like this isn't an attribute


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122091/new/

https://reviews.llvm.org/D122091