[PATCH] D122020: [WebAssembly] Add tests for the Asm type checker

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 21 09:12:21 PDT 2022


sbc100 added inline comments.


================
Comment at: llvm/test/MC/WebAssembly/type-checker-return.s:3
+
+; XFAIL: *
+
----------------
asb wrote:
> sbc100 wrote:
> > What is this line?   (is semi-colon a comment marker in .s files?)
> It is, but you're right it's confusing to have alongside `#` comments. The XFAIL is picked up by lit and indicates the test is expected to fail (in this case, the RUN line will return a non-zero value).
Oh, I normally use the `# RUN: not ...` for that.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122020/new/

https://reviews.llvm.org/D122020



More information about the llvm-commits mailing list