[PATCH] D122134: [WebAssembly] Always emit functype directives for defined functions

Alex Bradbury via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 21 08:59:00 PDT 2022


asb added inline comments.


================
Comment at: llvm/test/CodeGen/WebAssembly/byval.ll:24
+
 ; CHECK-LABEL: byval_arg
 define void @byval_arg(%SmallStruct* %ptr) {
----------------
sbc100 wrote:
> Can you just change this to `byval_arg:` instead?  (i.e. add a colon)
That is a much better solution to the problem - thanks!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122134/new/

https://reviews.llvm.org/D122134



More information about the llvm-commits mailing list