[PATCH] D122134: [WebAssembly] Always emit functype directives for defined functions

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 21 08:38:52 PDT 2022


sbc100 added inline comments.


================
Comment at: llvm/test/CodeGen/WebAssembly/byval.ll:24
+
 ; CHECK-LABEL: byval_arg
 define void @byval_arg(%SmallStruct* %ptr) {
----------------
Can you just change this to `byval_arg:` instead?  (i.e. add a colon)


================
Comment at: llvm/test/CodeGen/WebAssembly/cfg-stackify-eh.ll:21
+; NOOPT-LABEL: .section
+; NOSORT-LABEL: .section
+
----------------
Ditto.. i hope this isn't actually needed.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122134/new/

https://reviews.llvm.org/D122134



More information about the llvm-commits mailing list