[PATCH] D121572: [X86][NFC] Generate mnemonic tables

[Mikael Holmén via Phabricator via llvm-commits]

uabelho added a comment.

In D121572#3396262 <https://reviews.llvm.org/D121572#3396262>, @Amir wrote:

> In D121572#3396218 <https://reviews.llvm.org/D121572#3396218>, @uabelho wrote:
>
>> Hello,
>>
>> I noticed that if compilng with ubsan
>> -DLLVM_USE_SANITIZER='Undefined'
>> you get the following error when compiling llc with this patch:
>>
>> FAILED: lib/Target/X86/X86GenMnemonicTables.inc
>> cd /repo/uabelho/master-github/llvm/build-all-bbisdk-ubsan && /repo/uabelho/master-github/llvm/build-all-bbisdk-ubsan/bin/llvm-tblgen -gen-x86-mnemonic-tables -asmwriternum=1 -I /repo/uabelho/master-github/llvm/lib/Target/X86 -I/repo/uabelho/master-github/llvm/build-all-bbisdk-ubsan/include -I/repo/uabelho/master-github/llvm/include -I /repo/uabelho/master-github/llvm/lib/Target /repo/uabelho/master-github/llvm/lib/Target/X86/X86.td --write-if-changed -o lib/Target/X86/X86GenMnemonicTables.inc -d lib/Target/X86/X86GenMnemonicTables.inc.d
>> ../utils/TableGen/X86MnemonicTables.cpp:52:29: runtime error: load of value 170, which is not a valid value for type 'bool'
>> SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior ../utils/TableGen/X86MnemonicTables.cpp:52:29 in
>
> Hello and thanks for reporting! Working on it. Note there's an earlier report here: https://reviews.llvm.org/D121571#3396209

Great! Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121572/new/

https://reviews.llvm.org/D121572