[PATCH] D122065: [BOLT] Align constant islands to 8 bytes

[Amir Ayupov via Phabricator via llvm-commits]

Amir added a comment.

LGTM but I'm not an AArch64 expert. Rafael is on a vacation, so please tag someone knowledgeable from LLVM AArch64 community (e.g. git blame llvm/unittests/Support/Host.cpp in `TEST(getLinuxHostCPUName, AArch64)`) to double-check if it's a correct and the only constant island access restriction that needs to be enforced.



================
Comment at: bolt/test/runtime/AArch64/constant-island-alignment.s:1
+// This test checks that the constant island is aligned after bolt tool.
+// In case the nop before .Lci will be removed the pointer to exit function
----------------
nit: bolt tool -> BOLT


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122065/new/

https://reviews.llvm.org/D122065