[PATCH] D121921: [LoopInversionPass] Avoid pointless loop rotation

Amir Ayupov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 21 06:35:11 PDT 2022


Amir added a comment.

Can you please retitle to "[BOLT] Avoid pointless loop rotation"?



================
Comment at: bolt/test/X86/loop-inversion-pass.s:9
 # RUN: %clang %cflags %t.o -o %t.exe -Wl,-q
-# RUN: llvm-bolt %t.exe -data %t.fdata -reorder-blocks=cache+ -print-finalized \
+# RUN: llvm-bolt %t.exe -data %t.fdata -reorder-blocks=ext-tsp -print-finalized \
 # RUN:    -loop-inversion-opt -o %t.out | FileCheck %s
----------------
spupyrev wrote:
> yota9 wrote:
> > Just wondering what is the reason to change reorder-blocks alg here?
> 'cache+' and 'ext-tsp' are synonyms; this is different names of the same alg. 
> 
> I'll let someone else to get rid of 'cache+' altogether at some point )
Can you please keep cache+ here? We'll remove cache+ in a follow-up diff.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121921/new/

https://reviews.llvm.org/D121921



More information about the llvm-commits mailing list