[PATCH] D120953: [AArch64][SelectionDAG] Supports unpklo/hi instructions to reduce the number of loads

Mon Mar 21 06:04:28 PDT 2022

paulwalker-arm added a comment.

Thanks @Allen this works for me.  Before accepting I just wanted to double check your previous comment:

In D120953#3377136 <https://reviews.llvm.org/D120953#3377136>, @Allen wrote:

> Thanks very much, this version I firstly fix the crash as you mention, and this version only play as the beginning of such optimisation.
>
> If you agree, then I'll refact with your advice on the next version (**it is safest to exclude all scalable vector extending loads/truncating stores and then selectively enable those which we directly support.** ), and add more cases to guard them.

Is this something you can do for this patch? Or are you wanting to save that work for a follow on patch?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120953/new/

https://reviews.llvm.org/D120953